Hmm...

Harden release/STATE munger.
----------------------------
> - -DARCS_VERSION_WITH_PATCHES=$(shell sed -e 's/ (//' -e 's/ patches)//' -e 
> 's/+ /+/' release/STATE)
> +DARCS_VERSION_WITH_PATCHES=$(DARCS_VERSION)$(shell sed -n '/patches/ { s/.* 
> \([0-9]\+\) patches.*/+\1/; p }' release/STATE)

This appears to do the right thing, namely only looking for '+n patches'
and tidying up the output, leaving behind only the n part.  On the other
hand, it seems that release candidates and pre-releases presumably do
not get named anything more than $(DARCS_VERSION), which lead to the
unfortunate situation where somebody grabs a pre-release and thinks it's
the real thing.

This makes me wonder: maybe we should factor out the version number
logic in the current Setup.lhs, put it in a Distribution.VersionNumber
module, say.  Then we can recycle that fancy logic to convert the
release state into something that could be shared by make_snapshot.
Or is that just overkill?

What should we do?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Attachment: pgpNVt6cJw7Eq.pgp
Description: PGP signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to