On Thu, Dec 18, 2008 at 17:48:42 -0800, Trent W. Buck wrote:
> Clearly I didn't test the dist targets properly, because Petr has been
> having trouble with them as a result of my makefile cleanup.  My
> pitiful excuse is that they were so confusing and unusual that I
> didn't know how they were *supposed* to work ^_^;;;

Applied, thanks! (and sorry for my apparently shoddy review last time)

To "make dist" we need .depend.
-------------------------------
> - -ifeq (,$(filter slowdisttest dist% %clean config%,$(MAKECMDGOALS)))
> - -include autoconf.mk .depend .depend_p

> +ifeq (,$(filter %clean config% disttest,$(MAKECMDGOALS)))
> +include autoconf.mk
> +include .depend .depend_p

Makes sense to me... by the way, just checking that I understand the
filter correctly... I suppose this can be rewritten as:

ifeq (,disttest $(filter %clean config%,$(MAKECMDGOALS)))

(That's just me asking myself what the filter is for, and then
remembering that there is more than one target with that ends
in clean or starts with config)

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Attachment: signature.asc
Description: Digital signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to