Hi Gwern,

>> when foo $ do stuff
>>               moreStuff
>>               lastOfTheStuff
>
> (when packages up the 'if foo then bar else return ()' pattern.)

Fantastic idea, and really trival to add. It now finds 9 examples such as:

Darcs/Commands/Annotate.lhs:327:1: Use when
Found:
if wheni `elem` old_pis then
  do putAnn $ text "Following line added by " <> showPatchInfo wheni
     putLine ' ' l
  else return ()

Why not:
when (wheni `elem` old_pis) $
  (do putAnn $ text "Following line added by " <> showPatchInfo wheni
      putLine ' ' l)

I have fixed most of the issues reported on this list, and raised bugs
for the remaining ones. I've implemented an "ignore" feature,
documented it. I also included a section in a manual on how a user can
add their own hints such as above. I've also renamed the project to
"hlint" as suggested.

Thanks very much for all the helpful feedback that everyone has given.
I'll have a version released tomorrow with any luck!

Thanks

Neil
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to