On Tue, Dec 23, 2008 at 13:00:57 -0500, Gwern Branwen wrote: > Generally the complaint is something like 'your patches are hard to > read because of the whitespace changes; don't do that then'. > (Particularly true of Yi.)
Hmm interesting. I can see the point if, for example, neighbouring lines were changed (as opposed to the lines you actually changed for a non-prettification reason), but so long as it's stuff that you'd be changing anyway, and so long as it's only the trailing whitespace, I don't see the harm. Maybe they're on to something I'm missing. > > I think mine is something like > > "mumble mumble commute mumble" (I guess that argument could be addressed > > by submitting lots of little ws patches like you did, but then we're > > polluting the history). > > There's no winning, is there. :( One big patch doesn't commute, and a > lot of little patches pollutes the history, and mixing it into other > changes is unclear. > > (Wonder if the same objections would hold for hlint.) Yeah, Trent has had some experience with this. I think our conclusion was that a somewhat acceptable compromise would be to make these kinds of changes in thematic bundles, for example, one patch for all of Darcs.Patch.*, one for all of Darcs.Repository.*. Indeed, it's not a solved problem. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
