[email protected] writes:
> Thu Aug 6 06:27:06 EDT 2009 [email protected]
> * +script to run hlint on src/
Now that this work has been done (hooray!), some obligatory nitpicking.
Why do the patch names start with a "+"?
Test script doesn't follow the example (tests/EXAMPLE.sh, IIRC).
No license nor copyright declaration in .hint file.
What happens if the user has no hlint installed?
What happens if the user has too old an hlint installed?
Do the docs tell testers to install hlint ≥ <version>?
> we don't edit haskell_policy.sh directly because if there's a single
> warning or error it errors out and hlint generates >1k items
I'm not sure what you mean by this. How about redirecting hlint's
output to a file? This way the output within the test harness is
minimal, but users can see the exact error by consulting the report file.
hlint --hint=darcs-custom.hint ../src --report hlint.html >/dev/null ||
{
echo >&2 "Errors found by hlint! See $(dirname "$0")/hlint.html for
details."
exit 1
}
Incidentally, looking only at ../src/ causes Setup.lhs and
Distribution/*.lhs to be skipped. Any reason just ../ wouldn't work?
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users
