Since Trent didn't specify how to proceed [ ;-) ], Benjamin could you take a minute to amend this for the below and
darcs send --in-reply-to '<[email protected]>' Thanks! Eric (I think both of us would have been fine with just applying the patch as is, but what the heck) On Thu, Oct 01, 2009 at 23:29:12 +1000, Trent W. Buck wrote: > [email protected] writes: > > > Please take a look; I hope I have got this right (i.e. that it > > properly fails). > > Looks OK from visual inspection. Nitpicks follow. > > > +## Test for issue1632 - <SYNOPSIS: 'darcs changes > > dir/file-that-never-existed' > > +## should not list any patches.> > > The surrounding <SYNOPSIS: > part isn't needed. I would probably also > clarify that dir *does* exist (as far as pristine is concerned), e.g. > > darcs changes D/f should not list any changes, where D is part of > the repo and f is a non-existent file. > > ...since I'm assuming that "adddir dir/" must be recorded in order to > trigger this bug. > > > [...] > > +# This one lists no patches: > > +darcs changes non-existent-file | not grep 'added dir' > > +# But this one lists the dir creation patch: > > +darcs changes dir/non-existent-file | not grep 'added dir' > > I would prefer these comments to describe what *should* happen, rather > than the current behaviour, i.e. > > # Darcs should not list any changes here. > # Darcs should list the dir creation patch here. > > I would also redirect output (>log) so as to test Darcs' exit status, > e.g. > > not darcs changes dir/non-existent-file >log > not fgrep 'added dir' log > > _______________________________________________ > darcs-users mailing list > [email protected] > http://lists.osuosl.org/mailman/listinfo/darcs-users -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
