Ganesh Sittampalam <[email protected]> added the comment: I've applied the pull refactoring patches that were shared with patch39 (including the definePatches fix). Is it ok to apply the rest in logical chunks as I review them?
Some comments on the select changes refactor: > Fri Mar 19 13:59:13 GMT 2010 Florent Becker <florent.bec...@ens- lyon.org> > * resolve conflicts in AmendRecord.lhs > > Wed Feb 17 15:05:22 GMT 2010 Florent Becker <florent.bec...@ens- lyon.org> > * Simplify SelectChanges' interface and non-interactive part There are some unhelpful variable name changes - e.g. jobname -> jn in helpFor, opts -> o in with_selected_patchfrom_repo. Might be worth restoring the old names in a followup. shouldn't invertC be an instance of Invert a, Invert b => Invert (a :> b) ? Again might be nice for a followup. I understand from our IRC conversation that some of the changes are adding support for more combinations of options to support --reverse. __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch185> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
