Reinier Lamers <[email protected]> added the comment: Hi Florent, others,
I can't review the issue 1839 fix very well because I don't know in what way 'k' was broken. I can't easily reproduce it when I try to record something, and the ticket is not very informative. As for the issue 1843 fix, it looks OK if it works with the 'e' key. I'm going to check that now if my battery lets me. Some more comments I had while reading the code: In the first patch, "resolve issue1839: k broken in interactive selection", I see: > addfile ./tto What's that? > -textSelect' whch = do > - z <- gets tps > - when (not $ rightmost z) $ > +textSelect' whch = > + do > + z <- gets tps > + when (not $ rightmost z) $ Is this darcs coding style approved? I certainly use and favor the style that is removed here... And a general nagging comment about the SelectChanges code: why didn't you add many comments during the recent overhaul? Darcs.Patch.Choices is a good example of how it should be :) Bye, Reinier __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch245> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
