On Sun, Aug 08, 2010 at 15:20:02 +0200, Petr Rockai wrote:
> > Also, does createCache deal correctly with cache entries that are explicitly
> > marked readonly (in darcs sources, not in the filesystem mind you)?  Or is
> > that such a corner case that we shouldn't worry about it.
> 
> This whole block is guarded with "| writable", so I wouldn't worry about
> that.

...

> > Same request to Adolfo: please produce minimal patches to ensure fast 
> > review.
> I actually shuffled the createCache out of the inner block. Not sure the
> patch could be made any smaller.

Thanks for the clarification.  This would have been more evident to
me if I had actually taken the time to view your patch in a graphical
diff tool, tsk.

For now my workflow is

  darcs apply -i /tmp/foo.dpatch
  darcs-gdiff --last=1

with

  alias darcs-gdiff='darcs diff --diff-command='\''meld %1 %2'\'''

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
For a faster response, please try +44 (0)1273 64 2905.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to