Ganesh Sittampalam <[email protected]> added the comment: Actually I'm fine to review right now, there's just a risk of me disappearing for a while suddenly so assigning me reviews is a bit dicey.
Anyway, I've reviewed this and it looks fine so I'm pushing it. One strong suggestion for a followup is to rename the new 'State' type to 'ParserState' or similar to avoid confusion with the state monad. A minor style point I noticed: > + choice [ do ls <- lswew > + return (l:ls) (which itself is a refactoring from an explicit bind) could be expressed with <$> or fmap instead - choice [(l:) <$> lswew, ... ---------- assignedto: kowey -> ganesh status: needs-review -> accepted __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch337> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
