Eric Kow <[email protected]> added the comment: Hi Dmitry, many thanks for improving our test suite! It makes bugs easier to solve.
About the test: is "0401:19d2" really a minimal example of a filename with a colon on it? Maybe something simpler take makes fewer suggestions about what may be the actual problem would be good. Adding to that, it might also be nice to have *two* examples, one showing the expected behaviour on colons (c:/foo should be recognised as a windows path) and the minimal difference which makes Darcs go wrong (cx:/foo probably should not). Some admin stuff: may I ask for a little bit of extra help on your part? Could you re-submit this patch as a Darcs patch, following the conventions in http://wiki.darcs.net/Development/RegressionTests ? Little things like this help us (especially when multiplied by hopefully lots of users). [NB: if Dmitry does not get a chance to do this by 2010-09-01, we should just make a patch on his behalf, probably using one of our names, citing Dmitry in the patch log, which is ultimately less confusing IMHO] Also, it's perfectly fine (and admirable) to license your test as public domain, but I *think* [A] the "Public domain" and "(C)" are contradictory so you should probably choose one or the other and [B] what would really save effort on our part is to just use the MIT license from EXAMPLE.sh (because I think we'll just be tacking it on anyway). If you're at all curious about this sort of thing, see http://lists.osuosl.org/pipermail/darcs-users/2010-August/024770.html for my education on these matters. ---------- status: needs-review -> amend-requested __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch362> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
