Ganesh Sittampalam <[email protected]> added the comment:

> Fri Oct  1 14:58:02 PDT 2010  Simon Michael <[email protected]>
>   * hook env vars: add some haddocks

> Fri Oct  1 16:29:09 PDT 2010  Simon Michael <[email protected]>
>   * hook env vars: haddock improvement

These two look fine and I've pushed them.

> Fri Oct  1 15:01:49 PDT 2010  Simon Michael <[email protected]>
>   * hook env vars: clarify some conditional code

I don't understand the point of this - you've moved some code that's 
only used under #ifndef WIN32 outside the scope of that guard. Won't 
that just make warnings on WIN32?

> Fri Oct  1 15:56:02 PDT 2010  Simon Michael <[email protected]>
>   * hook env vars: rename defineChanges/definePatches for clarity

This depends on the previous patch so is stuck for now. Otherwise it's 
fine.

__________________________________
Darcs bug tracker <[email protected]>
<http://bugs.darcs.net/patch407>
__________________________________
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to