Ganesh Sittampalam <[email protected]> added the comment: I'm somewhat against this change. Most significantly, it introduces a QuickCheck dependency into our main codebase, and this could be problematic for users of the library because of the QuickCheck1/QuickCheck2 dependency fight.
Also, there's a design decision about our tests to make, namely whether they should have access to the internals of the thing they're testing or not (white-box versus black-box). My current feeling about the Patch hierarchy is that black-box testing is the best approach, at least for the bulk of the tests. I'd therefore like to keep the tests out of the source files they refer to and cut down on/eliminate the symbols that are exported just for test purposes. Finally, I'm currently knee deep in reorganising Darcs.Patch and this bundle would disrupt me rather, though it's not a strong reason if the consensus is in favour of it. __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch430> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
