Florent Becker wrote:

> clean up some dead code in Darcs.Patch
> --------------------------------------
> Ganesh Sittampalam <[email protected]>**20101017113941
> 
> dead code removal, except:
> 
> hunk ./src/Darcs/Patch/V2/Non.hs 180
>>            adj NilRL n = Just n
>>            adj (x:<:xs) n = fromPrim x >* n >>= adj xs
>> 
>> +-- TODO why don't any tests run this?
>>  propAdjustTwice :: (Patchy p, ToFromPrim p) => p C(x y) -> Non p
>>      C(y) -> Maybe Doc  propAdjustTwice p n = do n' <- p >* n
> 
> This is a little bit of a rider, but well...
> Also, what does propAdjustTwice do?

I'd love to know myself! yes, I should have made that a separate patch
(though it's kind of a clean-up of dead code, in that the code is
currently dead and I'm making a note that we should do something about
this rather than just deleting it :-)

> drop unused flag
> ----------------
> Ganesh Sittampalam <[email protected]>**20101017114053
> 
> Great, at least we get rid of that flag. For how long has it been a
> dud? 

>From memory, Petr removed the implementation behind it
(willStoreInMemory) sometime in the last year or so.

Ganesh

=============================================================================== 
Please access the attached hyperlink for an important electronic communications 
disclaimer: 
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html 
=============================================================================== 

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to