Florent Becker <[email protected]> added the comment:

remove locale sensitivity from send output tests
------------------------------------------------
Ganesh Sittampalam <[email protected]>**20101022204106

This is not robust, because it matches on Oct 1, which has been
updated to Oct 20 by some later patch. Better get the date from the
bundle. I don't want to further delay application because of this, and
I'm sending a followup myself, please review it.


hunk ./tests/send-output-v1.sh 42
>  cd repo
>  darcs send -o repo.dpatch -a ../empty
>  
> -diff -u -I'1 patch for repository ' -I'patches for repository ' 
$TESTDATA/simple-v1.dpatch repo.dpatch
> +diff -u -I'1 patch for repository ' -I'patches for repository ' -
I'Oct 1' $TESTDATA/simple-v1.dpatch repo.dpatch
>  cd ..
>  
>  # context-v1 tests that we are including some context lines in hunk 
patches

'Oct 1' is no longer up to date

hunk ./tests/send-output-v1.sh 51
>  cd repo
>  darcs send -o repo.dpatch -a ../empty
>  
> -diff -u -I'1 patch for repository ' -I'patches for repository ' 
$TESTDATA/context-v1.dpatch repo.dpatch
> +diff -u -I'1 patch for repository ' -I'patches for repository ' -
I'Oct 1' $TESTDATA/context-v1.dpatch repo.dpatch
>  cd ..

idem

hunk ./tests/send-output-v2.sh 42
>  cd repo
>  darcs send -o repo.dpatch -a ../empty
>  
> -diff -u -I'1 patch for repository ' -I'patches for repository ' 
$TESTDATA/simple-v2.dpatch repo.dpatch
> +diff -u -I'1 patch for repository ' -I'patches for repository ' -
I'Oct 1' $TESTDATA/simple-v2.dpatch repo.dpatch
>  cd ..
>  
>  # context-v1 tests that we are including some context lines in hunk 
patches

idem

hunk ./tests/send-output-v2.sh 51
>  cd repo
>  darcs send -o repo.dpatch -a ../empty
>  
> -diff -u -I'1 patch for repository ' -I'patches for repository ' 
$TESTDATA/context-v2.dpatch repo.dpatch
> +diff -u -I'1 patch for repository ' -I'patches for repository ' -
I'Oct 1' $TESTDATA/context-v2.dpatch repo.dpatch
>  cd ..

idem

----------
status: review-in-progress -> followup-in-progress

__________________________________
Darcs bug tracker <[email protected]>
<http://bugs.darcs.net/patch421>
__________________________________
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to