Hi, You could also apply this patch in the 1.6.x branch, it's really a simple patch.
Anyway, I did go the easy route: I've add a config in GUI options just below "ask before erasing images from disk". The new config is "send files to trash when erasing images". It's uncheck by default to keep the previous behaviour but maybe it should be checked by default? It's a minor change. So the GUI is unchanged: it still asks "do you really want to physically delete 1 selected image from disk?" but the file is sent to the trash instead. It works for images but also for XMP when the deleted file is a duplicate. Guillaume On Sun, Aug 23, 2015 at 2:28 PM, Sebastian wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > I'm not a dev, just an experienced user. And I can't test it as master > depends on Gtk 3. > > I generally would like this feature implemented in darktable as many new > users are accustomed to the trash-behavior. But I'm interested in the > UI-part: > Is this patch adding a new button in the selected-images module? How > does this button integrate to the 2 exiting buttons remove and delete, > is it in the middle of them? > > Sebastian > > On 08/09/2015 08:11 PM, Guillaume Benny wrote: >> Hi, >> >> I have been using darktable for a few months now and I really like > it. I recently thought of a feature that would be useful (to me at > least): sending deleted files to trash instead of permanently deleting them. >> >> Since I'm a C++ dev for my day job, I decided to try to implement it. > I've attached the patch for the master branch. It works well as far as I > could test it. >> >> I hope this can be merged! >> >> Guillaume >> >> >> >> >> > ___________________________________________________________________________ > darktable developer mailing list to unsubscribe send a mail to > [email protected] >> >> -- >> python programming - mail server - photo - video - https://sebix.at >> To verify my cryptographic signature or send me encrypted mails, get my >> key at https://sebix.at/DC9B463B.asc and on public keyservers. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > > iQIcBAEBCAAGBQJV2hDPAAoJEBn0X+vcm0Y7qcwP/1ePhkq0/S5z6vp9n8JlvDxl > yl5/8gUKZGpw90UzBG0UWCYUjX6fuCocJlOOEepJTWA787n9wq8Rbx0Kn2yP6V5G > na9ohG4MD3j1be55HpYnPNfubySvUu+/8HUSL6nsUW0bu3RkTWX5EZD0IN1V088o > SWkCYleL4vswPbBi2kF6OsOcg7NP3n7KSCbSK91tSic4r8BjDUfMz/kLvgvTKFey > JTHnrcKWGtcIRhbZf7jiDZznLqGYn2XVc5q6T5/liY1IAA058Pl2ADWuMvD1u8aG > ZwQnc8QNLru2Sj9X2ub/rvU/La7/CLD2pjlrpUnvQs7Irng75a1LEQUnQdV2dXoX > TACsdsLSPI7KdcX2eikXS4U8nkcSZ/ovgxfw0EIUpiUU6fM7RafP61NUj4zcwL2O > WAjZY0ojN4blynbItlGkRQIUV/1ar+iPwj0ys7ChCWDy60zPTmamI6yoQLBG52sb > WgPkHIIw60wuqFJafSKoWD5mlPt9bGKIQAYGQUwVBOGOFqKKxaAU9yYOBExoRfNv > Q5pbJ5OzoNZdNqZ3yyhSa3jMwd3bWQ0ggWMW6SfXbR3xtOIg819yk9OUKWWr2/3T > oUHwTZYEoky26A87VHnu6Vtx79WwbWFQSC5FDAykungrEBEtrCgE78iFo3f4h0+M > nWJkr+bhA3HMcQnxbHI6 > =A3pr > -----END PGP SIGNATURE----- > > > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to [email protected] > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to [email protected]
