Am 09.04.2017 um 09:31 schrieb Roman Lebedev:
On Sun, Apr 9, 2017 at 9:59 AM, Ulrich Pegelow
<ulrich.pege...@tongareva.de> wrote:
Am 08.04.2017 um 20:04 schrieb Roman Lebedev:

Well, that is *very* strange indeed.
If it *reliably* happens for you, then maybe you could also bisect this
within the submodule itself?


Very clear result:
Aha, now that makes rather no sense.
It is likely caused by just one raw image, if you can find it, i'll
take it from here.

7f087325d09e2b6d4ecc392f7aee44dd29fafe62 is the first bad commit
commit 7f087325d09e2b6d4ecc392f7aee44dd29fafe62
Author: Roman Lebedev <lebedev...@gmail.com>
Date:   Sat Apr 1 13:11:57 2017 +0300

    ThrowException(): and how about this?

:040000 040000 84dd635a545bf913c916bc075f152a6718f05b1b
ba3c956bb4ffb0b8f54b55ac4aaaf879334f7327 M      src
This commit was reverted in the very next commit, so what is the next
bad commit?


Looks like none of the following commits solves the issue.

However, looking at the changes in question I found that the following patch in master brings darktable back to normal:

diff --git a/src/librawspeed/common/RawspeedException.h b/src/librawspeed/common/RawspeedException.h
index 692d3f9..b0ebee6 100644
--- a/src/librawspeed/common/RawspeedException.h
+++ b/src/librawspeed/common/RawspeedException.h
@@ -32,7 +32,7 @@
 namespace RawSpeed {

 template <typename T>
-[[noreturn]] static inline void __attribute__((noreturn, format(printf, 1, 2)))
+[[noreturn]] void __attribute__((noreturn, format(printf, 1, 2)))
 ThrowException(const char* fmt, ...) {
   static constexpr size_t bufSize = 8192;
 #if defined(HAVE_THREAD_LOCAL)

That means reverting the change from commit 7f087325d09e2b6d4ecc392f7aee44dd29fafe62 which has not yet been reverted in commit 0967e3c8a528cca0800cc5289cba5c212a385a6b.

Don't ask me ....

Ulrich


___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Reply via email to