Hi,

darktable is written in C99, which has introduced variable length arrays into the C programming language. This feature is used several times in the darktable source. Therefore, I wonder why the file
compiler-warnings.cmake contains the line

CHECK_COMPILER_FLAG_AND_ENABLE_IT(-Wvla)

Furthermore, the darktable source contains at several places the pragma

#pragma GCC diagnostic warning "-Wvla"

I do not understand why these warnings are enforced. In the case that there is something wrong with variable length arrays we should avoid them completely. Otherwise one should remove the warnings.


        Heiko


--
-- Number Crunch Blog @ https://www.numbercrunch.de
--  Cluster Computing @ http://www.clustercomputing.de
--       Professional @ https://www.mpi-hd.mpg.de/personalhomes/bauke
--  Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Reply via email to