And thanks to boucman, I've just corrected 1 more bug and add an easy feature. The Pull request should have been automatically updated.
Just a question here : is this PR with about 5 commits clean enough to be reviewed, or should I create a new branch, rebase and do another PR ? Thanks, Aldric Le 28/11/2012 11:23, AlicVB a écrit : > ok, thanks > I answer you directly there too... > ...and I add a new commit to change boolean for int and to correct an > obvious bug. > > Aldric > > Le 28/11/2012 04:20, johannes hanika a écrit : >> i put some comments on github, it's easier to talk about specific >> lines of code that way :) >> >> cheers, >> jo >> >> >> On Mon, Nov 26, 2012 at 11:21 AM, AlicVB <[email protected]> wrote: >>> Hi all, >>> Now that release has been done (great work, btw), it's time for new >>> stuff, >>> right ? >>> So I have on a branch a new system for keystone modifications. >>> The difference is that you make modification directly on the image. >>> Screenshot attached. >>> >>> Please have a look : >>> https://github.com/AlicVB/darktable branch key >>> >>> Be careful that when you'll switch back to the master, all modifs to >>> the >>> "clipping" module may be lost... >>> >>> All feedbacks are welcome. >>> Thanks >>> >>> Aldric (aka alicvb) >>> >>> PS : the drawing on the image need more work, it's quite ugly for >>> instance ! >>> >>> ------------------------------------------------------------------------------ >>> >>> >>> Monitor your physical, virtual and cloud infrastructure from a single >>> web console. Get in-depth insight into apps, servers, databases, >>> vmware, >>> SAP, cloud infrastructure, etc. Download 30-day Free Trial. >>> Pricing starts from $795 for 25 servers or applications! >>> http://p.sf.net/sfu/zoho_dev2dev_nov >>> _______________________________________________ >>> darktable-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/darktable-devel >>> > ------------------------------------------------------------------------------ Keep yourself connected to Go Parallel: VERIFY Test and improve your parallel project with help from experts and peers. http://goparallel.sourceforge.net _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
