Richard,
> That PR, however, doesn't solve what Pascal is complaining about.
Right.
> I'm working on the problem that Pascal mentions as well ('cause it has
> annoyed the hell out of me as well).
> However, there are things related to this that I wonder about... For
> completeness, the following things would need to be saved with the
> image (in dt_iop_clipping_params_t):
>
> - aspect ratio (I'd like to save it as numerator and denominator
> separately, for the sake of showing it in the GUI later on... or
> would it be sane to save it in text form?)
> - aspect ratio preset (int)
> - aspect ratio preset flipped (bool)
>
> That basically mimicks what is currently saved in darktablerc. Does
> that seem sane?
Looks overcomplicated. I have a very simple patch which is working.
Testing right now. The actual aspect can be computed from the current
image and crop. Nothing fancy but it works. No need to save additional
value into the iop params.
Pascal.
--
Pascal Obry / Magny Les Hameaux (78)
The best way to travel is by means of imagination
http://v2p.fr.eu.org
http://www.obry.net
gpg --keyserver keys.gnupg.net --recv-key F949BD3B
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
