Hi, the code is now on the main repo, branch "masks2" no big changes, except that xmp read/write is almost ok (still a little bug with double value, ...)
Feel free to test and comment. Aldric Le 16/01/2013 21:25, AlicVB a écrit : > hi all, > > After some evenings of work, I've a mask implementation which work. > For those who want to test, you can find the code here : > https://github.com/AlicVB/darktable.git branch clone2 (and I know that > the name could me more descriptive...) > be careful that it's just a draft. There's lot of things remaining, > it's _very_ easy to crash dt, with that... > > for users : > - forms can be added with the "multi-instance" menu. for instance you > can just add circles > - once you added a form, you will see it on the bottom of the module > gui (just before blending) > - click on a form to see it and/or modify it on screen > > for devs, here is how I implement this : > - all forms are kept on the image level and store in a separate db > table, so it will be possible to use the same form on 2 different iop. > - on the iop/history level, we just store form's id (in blend params) > - I've added 2 files : develop/masks.c .h to store all related code > - forms can be used for mask and/or cloning (spot removal). > - other type of forms can be added (polygons, curves, ...) for > instance, just circles are here, but Henrik has some code for curves > (I've some code too). > - For rendering, I've used the blend routine. I apply mask before > blending, so we can use mask + blendif :) > > What is not possible for instance, but will be coded asap : > - no opencl > - can't remove forms > - can't reuse forms > - no curves, just circles for instance > - no xmp save/load > - no presets/styles,... > > I've added a screenshot as a proof ;) > > Please remember that it's not definitive code. No need to report bugs > for instance... > At this stade, I'm manly interested in comment from the devs on the > implementation. > > Thanks > Aldric > > PS : with all the snow here, my internet connexion is a little bit > unstable, so no IRC this evening :( maybe tomorrow at work ... > > ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
