Confirmed, I've a working 1.1+1341~g4ad106b :-) Cheers, Richard
In message <[email protected]> on Sun, 17 Mar 2013 16:23:01 +0100, AlicVB <[email protected]> said: alic.vb> ok, I just push a fix for this. alic.vb> Please try again and report if it works now... alic.vb> alic.vb> Aldric alic.vb> alic.vb> Le 17/03/2013 12:59, AlicVB a écrit : alic.vb> alic.vb> Hi, alic.vb> problem seems to come from my last commit on this file (big patch to correct lot of bugs and alic.vb> strange behavior of the module). alic.vb> I see the root cause : self->dev is NULL. The question is more how to get a work around to get alic.vb> the image size. alic.vb> Will try to correct this as soon as possible. alic.vb> alic.vb> thanks for reporting alic.vb> alic.vb> Aldric alic.vb> Le 17/03/2013 12:16, Richard Levitte a écrit : alic.vb> alic.vb> Hi, alic.vb> alic.vb> I've built the latest revision I can get (1.1+1329~g1728e4d), and I'm alic.vb> getting a sigsegv. The automatically generated backtrace shows me alic.vb> that it happens in src/iop/clipping.c:190. A manual session later, I alic.vb> find myself with this: alic.vb> alic.vb> Program received signal SIGSEGV, Segmentation fault. alic.vb> 0x8b99fe40 in legacy_params (self=0x9c257ff0, old_params=0x9c2576d8, alic.vb> old_version=4, new_params=0x9c258520, new_version=5) alic.vb> at /home/levitte/gitwrk/github.com/darktable-1.1+1329~g1728e4d/src/iop/clipping.c:190 alic.vb> 190 float whratio = ((float)(self->dev->image_storage.width - 2 * interpolation->width) * (fabsf(n->cw) - n->cx)) / alic.vb> (gdb) print *n alic.vb> $1 = {angle = -0.699996948, cx = 0.0587422848, cy = 0.0702050403, alic.vb> cw = 0.992118239, ch = 0.691418171, k_h = 0, k_v = 0, kxa = 0.200000003, alic.vb> kya = 0.200000003, kxb = 0.800000012, kyb = 0.200000003, kxc = 0.800000012, alic.vb> kyc = 0.800000012, kxd = 0.200000003, kyd = 0.800000012, k_type = 0, alic.vb> k_sym = 0, k_apply = 0, crop_auto = 1, ratio_n = 0, ratio_d = 0} alic.vb> (gdb) list alic.vb> 185 // if no clipping yet, use default aspect ratio alic.vb> 186 if (fabsf(n->cw) == 1.0 && n->cx == 0.0 && fabsf(n->ch) == 1.0 && n->cy == 0.0) n->ratio_d=-1, n->ratio_n=-1; alic.vb> 187 else alic.vb> 188 { alic.vb> 189 const struct dt_interpolation* interpolation = dt_interpolation_new(DT_INTERPOLATION_USERPREF); alic.vb> 190 float whratio = ((float)(self->dev->image_storage.width - 2 * interpolation->width) * (fabsf(n->cw) - n->cx)) / alic.vb> 191 ((float)(self->dev->image_storage.height - 2 * interpolation->width) * (fabsf(n->ch) - n->cy)); alic.vb> 192 float ri = self->dev->image_storage.width / (float)self->dev->image_storage.height; alic.vb> 193 alic.vb> 194 float prec = 0.0003f; alic.vb> (gdb) print *interpolation alic.vb> value has been optimized out alic.vb> (gdb) print interpolation->width alic.vb> value has been optimized out alic.vb> (gdb) print self->dev->image_storage alic.vb> Cannot access memory at address 0x5c alic.vb> (gdb) print self->dev alic.vb> $2 = (struct dt_develop_t *) 0x0 alic.vb> (gdb) print self alic.vb> $3 = (dt_iop_module_t *) 0x9c257ff0 alic.vb> (gdb) bt alic.vb> #0 0x8b99fe40 in legacy_params (self=0x9c257ff0, old_params=0x9c2576d8, alic.vb> old_version=4, new_params=0x9c258520, new_version=5) alic.vb> at /home/levitte/gitwrk/github.com/darktable-1.1+1329~g1728e4d/src/iop/clipping.c:190 alic.vb> #1 0xf7e58295 in init_presets (module_so=0x9c255648) alic.vb> at /home/levitte/gitwrk/github.com/darktable-1.1+1329~g1728e4d/src/develop/imageop.c:1307 alic.vb> #2 dt_iop_load_modules_so () alic.vb> at /home/levitte/gitwrk/github.com/darktable-1.1+1329~g1728e4d/src/develop/imageop.c:1438 alic.vb> #3 0xf7df3d73 in dt_init (argc=argc@entry=1, argv=argv@entry=0xffffd014, alic.vb> init_gui=init_gui@entry=1) alic.vb> at /home/levitte/gitwrk/github.com/darktable-1.1+1329~g1728e4d/src/common/darktable.c:669 alic.vb> #4 0x08048963 in main (argc=1, argv=0xffffd014) alic.vb> at /home/levitte/gitwrk/github.com/darktable-1.1+1329~g1728e4d/src/main.c:24 alic.vb> (gdb) alic.vb> alic.vb> Cheers, alic.vb> Richard alic.vb> alic.vb> P.S. Attaching the automagically genetared backtrace. alic.vb> alic.vb> ------------------------------------------------------------------------------ alic.vb> Everyone hates slow websites. So do we. alic.vb> Make your web apps faster with AppDynamics alic.vb> Download AppDynamics Lite for free today: alic.vb> http://p.sf.net/sfu/appdyn_d2d_mar alic.vb> alic.vb> _______________________________________________ alic.vb> darktable-devel mailing list alic.vb> [email protected] alic.vb> https://lists.sourceforge.net/lists/listinfo/darktable-devel alic.vb> ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
