On Mon, 18 Mar 2013 17:28:59 +0100
jeremy rosen <[email protected]> wrote:

> IIRC there are two modes when pasting style, paste and append.
> 
> when pasting, we actively want to replace the existing iop with the ones
> from the style. so it makes sense to remove all previous iop and add our
> instances instead. so in your case, the pasted instance would become #0
> 
> when appending we want to add our changes, so I think it should become a
> new instance #n+1 depending on how many instances the image already had.
> The previous behaviour of appending (that would not touch iop if they arn't
> in the pasted style and replace if they were) does not make sense now that
> we have MI

I strongly disagree, we shouldn't change behavior like that. The way it
was without MI has its use-cases and people may rely on that (I know I
do). Plus I think you're confusing styles with copy-paste,
style-applying always was in append mode, there's no overwrite mode for
them.

> 
> I think that would be a simple and consistent behaviour. what do other
> people think ?
> 
> 
> On Mon, Mar 18, 2013 at 5:11 PM, Pascal Obry <[email protected]> wrote:
> 
> >
> > Doing some more testing on copy and style and multi-instance it works
> > but there is some behavior that we probably want to adjust.
> >
> > For example:
> >
> > 0. from an image with 2 instances of the same module
> >
> > 1. create a style from this image and select the second
> > (multi_priority=1) instance for this module.
> >
> > 2. apply this style to another image, it will apply the iop to the new
> > image but as a second instance (=1) and the first one (=0) is just
> > disabled.
> >
> > Wouldn't it be better to have the instance priority renamed to 0 in this
> > case?
> >
> > The same issue can be reproduced with partial copy I suppose.
> >
> > What do you think?
> >
> > --
> >   Pascal Obry /  Magny Les Hameaux (78)
> >
> >   The best way to travel is by means of imagination
> >
> >   http://v2p.fr.eu.org
> >   http://www.obry.net
> >
> >   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
> >
> >
> > ------------------------------------------------------------------------------
> > Everyone hates slow websites. So do we.
> > Make your web apps faster with AppDynamics
> > Download AppDynamics Lite for free today:
> > http://p.sf.net/sfu/appdyn_d2d_mar
> > _______________________________________________
> > darktable-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/darktable-devel
> >

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to