It seems we have a quite big bug in the way num (history stack or style iop number) is handled. Scenario:
- create a style from an image with many iop, select only 2 iop in the list - the num recorded into the style are those from image - they are therefore non continuous (maybe 2 and 7). - when you apply a style to another image we add an offset to the num from the style - this offset is (select count(num) ...) - if we have a single iop in the image, the style items will be applied as 3 and 8. Here we are counting the number of current item in history, but it is wrong as the current max num could be above COUNT(num). Indeed reapply the same style COUNT(num) is 3 but the offset should be 8. I see 2 solutions: 1. always cleanup the history stack after applying a style or pasting to ensure that num starts to 0 and increment one by one. OR 2. using MAX(num) instead of COUNT(num) The second solution above is simpler of course, but maybe it is mandatory in dt to have the history stack items numbers continuous. Thoughts? -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.gnupg.net --recv-key F949BD3B ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
