Am 12.04.2013 21:27, schrieb Pascal de Bruijn: > On Sun, Apr 7, 2013 at 1:43 PM, Pascal de Bruijn <[email protected]> wrote: >> >> Hi, >> >> It seems Exiv2 is syncing it's lens names with ExifTool for some brands, >> however, that does mean some will break lensfun matching (if fuzzy matching >> is not used)... >> >> http://dev.exiv2.org/projects/exiv2/repository/revisions/3004/diff/trunk/src/canonmn.cpp >> http://dev.exiv2.org/projects/exiv2/repository/revisions/3003/diff/trunk/src/pentaxmn.cpp >> >> Particularly these changes: >> >> From: { 10, "Canon EF 50mm f/2.5 Macro" }, >> // 0 >> To: { 10, "Canon EF 50mm f/2.5 Macro or Sigma Lens" }, // 0 >> >> So the " or Sigma Lens" part will make strict matching fail for Lensfun... >> >> I don't really want us to go back to fuzzy matching, and the sensible thing >> to do, seems to be to cut off anything past ' or ' before passing the string >> to lensfun... >> >> I attached some proof of concept code, I hope you guys can take a look to >> see if I've done nothing too silly (introduced a memory leak etc :). > > Ulrich, > > Would you mind taking a look? Although my sample code seems to work, > I'm not sure what the best approach is to integrate it into lens.c >
Will do during the weekend :) Ulrich ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
