Also see http://darktable.org/redmine/issues/9242 That bug will probably be fixed by this change.
On Mon, 15 Apr 2013 22:20:54 -0700 Daniel Wagenaar <[email protected]> wrote: > In Darktable 1.2 (and perhaps other versions), there is a discrepancy > between the tooltip for the "core options/demosaicing for zoomed out > darkroom mode" preference and the actual behavior of demosaicing in > darkroom mode: The tooltip (and the name of the option) suggests that > demosaicing algorithm is only overwritten by this option when zoom is > less than 1:1. In fact, it is overwritten even when zoom is 1:1 or > larger. The relevant code is line 671 in demosaic.c: > > const int qual = get_quality(); > int demosaicing_method = data->demosaicing_method; > if(piece->pipe->type == DT_DEV_PIXELPIPE_FULL && qual < 2) // only > overwrite setting if quality << requested and in dr mode > demosaicing_method = DT_IOP_DEMOSAIC_PPG; > > I think this should be: > > const int qual = get_quality(); > int demosaicing_method = data->demosaicing_method; > if(piece->pipe->type == DT_DEV_PIXELPIPE_FULL && qual < 2* && > roi_out->scale<=.99999f*) // only overwrite setting if quality << requested > and in dr mode > demosaicing_method = DT_IOP_DEMOSAIC_PPG; > > > Naturally, I would be happy to submit this as a patch, but it is perhaps > so simple that some existing developer can just take care of it. > (Assuming that you agree.) > > - Daniel Wagenaar > -- > Daniel A. Wagenaar, PhD > Assistant Professor, arriving August 2013 > Department of Biological Sciences > McMicken College of Arts and Sciences > University of Cincinnati > Cincinnati, OH 45221 > Phone: +1 (626) 395-2577 > Email: [email protected] > Web: http://www.danielwagenaar.net ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
