Hi Pascal, confirmed. The best way is probably to init dev->form_gui->edit_mode from the blendop settings within the module in question. I will take care.
Ulrich Am 23.07.2013 11:14, schrieb Pascal Obry: > We can only remove one shape, after nothing happen. > > To reproduce: > > - a 2 circles in the spots removal iop > - right click on one (it is removed as expected) > - right click on the other (nothing happen) > > The only solution is to close and re-open the spot removal module. > > This is a regression. I have a patch, but I'm not sure it is correct and > fear it interfere with the restricted edit mode. All this code is not clear > to me and I'l blocked. Need help. > > So what do you think about this patch: > > <<< > diff --git a/src/develop/masks/masks.c b/src/develop/masks/masks.c > index b3264ef..1153c31 100644 > --- a/src/develop/masks/masks.c > +++ b/src/develop/masks/masks.c > @@ -731,7 +731,6 @@ void dt_masks_init_formgui(dt_develop_t *dev) > > dev->form_gui->group_edited = -1; > dev->form_gui->group_selected = -1; > - dev->form_gui->edit_mode = DT_MASKS_EDIT_OFF; > } > > void dt_masks_change_form_gui(dt_masks_form_t *newform) >>>> > ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
