Stefan,

I think from what I am seeing these questions may be better put to
https://discuss.pixls.us/c/software/darktable

as those devs seem to be active there.

--

regards
Bernhard

https://www.bilddateien.de

Bernhard schrieb am 20.01.20 um 18:49:


dt-l...@stefan-klinger.de schrieb am 19.01.20 um 22:55:
Stefan Klinger (2020-Jan-19, excerpt):
or there might be a sign error in “filmic” (that nobody has
noticed?!).
Now this "change" (I'm not claiming it to be a "fix"), would give me
bahaviour I personally would expect: In `src/iop/filmicrgb.c` change

     p->black_point_source = p->black_point_source - grey_var;

to

     p->black_point_source = p->black_point_source + grey_var;

It pretty much lets white and black at where I've set them and only
changes grey.  But hey, I've just changed a sign in the middle of a
formula I don't understand....

Two more things:

Under “look”, when I move the “shadows/highlights balance” to the
right, the linear area in the diagram moves right.  Could someone
please flip this?

I think it would be nice if the sliders for white, black, and grey
under “display” would be in the same order as under “scene”, so it'd
be easier to see where your values get mapped.

Cheers,
Stefan

Since I skipped dt 2.6 because of not having an OS providing the necessary dependencies I'm new to filmicRGB. What I noted is that I use the white relative slider this does _not_ only move the white point but stretches (or shrinks) the histogram on both ends so afterwards I have to recover the clipped shadows.
I don't know if this is intended.
In comparison moving the black relative slider I do only see minor changes at the highlight end of the histogram.


____________________________________________________________________________
darktable user mailing list
to unsubscribe send a mail to darktable-user+unsubscr...@lists.darktable.org

Reply via email to