Hi Ashley, > I'd just like to know what other people think of my interpretation of > #save/#save!.
The intention with the 0.10 behavior is: #save - save the resource with hooks applied #save! - save the resource without any hooks applied Also #create, #destroy, #update all should conform to this behavior across Resource, Collection and Model. > One of the two > main conventions of #<method>! is to raise errors (the other being to > modify the receiver). So I'm happy that #save! reraises persistence > errors. I think the bang/non-bang convention you mention is actually Rails specific. With DM we're trying to design according to the following interpretation of their usage: http://dablog.rubypal.com/2007/8/15/bang-methods-or-danger-will-rubyist So the non-bang version is considered safe, and the bang is unsafe. The bang method bypasses checks, and any tests that may have been installed by plugins (like dm-constraints and dm-validations) and just goes straight to the datastore and modifies the data directly. > I think that having a #save method that catches all errors is > important - it means you can guarantee your app will not generated an > unexpected 500 error. In other words, I'm happy with the current #save. Actually in most cases we don't attempt to catch datastore exceptions. We just let them bubble them up. It might look like we catch all errors, but that's not us, that's you using dm-validations and dm-constraints. Those libs act as a gate keeper in front of the datastore, short circuiting alot of things that wouldn't work before the datastore even sees them. By the time a datastore exception happens it's usually too late for DM to recover in a sane consistent manner anyway, so I would only consider catching those exceptions if I was to add more debug info, and then rethrow the exception up the stack. -- Dan (dkubb) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DataMapper" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/datamapper?hl=en -~----------~----~----~----~------~----~------~--~---
