> 
> On Tue, 11 Feb 2003, Rich Bowen wrote:
> 
> > On Thu, 6 Feb 2003, Hill, Ronald wrote:
> >
> > > Hi All,
> > >
> > > This is to announce a new release of Astro::Sunrise perl module.
> > > This is a complete rewrite of the module/added new functionality.
> >
> > If I might be so bold, it's nice to list prerequisites. Of 
> course, now
> > I'm having trouble getting the prerequisite to build, but that's not
> > your fault ... ;-)
> 
> I see I missed another one.

Sorry about that :-( I have added the prereq to the distribution.

As you know this is a rewrite of the module (to make it more in
line with Paul's C code) Apparently, I missed this one !!

Another difference that you will notice is this:

if ( $cost >= 1.0 ) {
        carp "Sun never rises!!\n" if $^W;
        $t = 0.0;    # Sun always below altit
    }
    elsif ( $cost <= -1.0 ) {
        carp "Sun never sets!!\n" if $^W;
        $t = 12.0;    # Sun always above altit
    }
    else {
        $t = acosd($cost) / 15.0;    # The diurnal arc, hours
    }

>From Paul's C code
/*               +1 = sun above the specified "horizon" 24 hours.     */
/*                    *trise set to time when the sun is at south,    */
/*                    minus 12 hours while *tset is set to the south  */
/*                    time plus 12 hours. "Day" length = 24 hours     */
/*               -1 = sun is below the specified "horizon" 24 hours   */
/*                    "Day" length = 0 hours, *trise and *tset are    */
/*                    both set to the time when the sun is at south. 


Before I would return an error. Now I am returning an actual value
(when sun is at south). I need to document this change (silly me!!)
This has caused some confusion.

I don't know if I am doing the correct thing here. Because, some
people do not run with warnings turned on (evil!!)
Well, I will try it and see if I get any complaints if so then 
I will need to rethink things.
  
> 
> >
> > [root@riesling Astro-Sunrise-0.6]# diff -Bbu Makefile.PL.orig
> > Makefile.PL
> > --- Makefile.PL.orig    2003-02-11 06:45:34.000000000 -0500
> > +++ Makefile.PL 2003-02-11 06:46:31.000000000 -0500
> > @@ -4,4 +4,7 @@
> >  WriteMakefile(
> >      'NAME'     => 'Astro::Sunrise',
> >      'VERSION_FROM' => 'Sunrise.pm', # finds $VERSION
> > +    'PREREQ_PM' => {
> > +      'Time::Object' => 0,
>   +      'Time::Seconds' => 0,
> > +    },
> >  );

I had many requests for some kind of interface to the other time
modules So I chose the time object interface again, this is
not set in stone!!

There has been a lot of activity on the datetime perl list as of late.
maybe when things get stable I will use that!!

Hope you enjoy the module!!

Thanks

Ron Hill

Reply via email to