On Thu, 10 Jun 2004, Jaldhar H. Vyas wrote: > While malingering from actual work, I wrote some code to convert dates to > and from the Discordian calendar. Over the past couple of nights I made > it into a proper DateTime::Calendar module which I posted to PerlMonks > (http://www.perlmonks.org/index.pl?node_id=362936) This morning I also > packaged it up into a proper CPAN package which you can find at > http://src.braincells.com/perl/ > > Before I upload it to CPAN, I'd like you to review it and suggest any > improvements, bugfixes etc.
Well, Rich Bowen had started working on the same module, so you should talk to him. Reviewing the code/docs, I have a couple nits: - The constructor shouldn't take rd_secs, rd_nanosecs, or locale, I don't think. The only way to set this should be via the from_object method. - I'm assuming that the "holyday" spelling is intentional, right? - days_till_x should be days_until_x. I'm not a big fan of abbreviations in general, unless they're ridiculously obvious, and "till" is the wrong abbreviation anyway ;) - You have %% documented twice. - Using ü in the exclamations probably isn't right. This is part of Latin-1, so use that character. -dave /*======================= House Absolute Consulting www.houseabsolute.com =======================*/
