I noticed a little bug today. DateTime::Event::Recurrence modifies the parameters that are passed to it.

I suspect these lines..

Index: lib/DateTime/Event/Recurrence.pm
===================================================================
RCS file: /cvsroot/perl-date-time/modules/DateTime-Event-Recurrence/lib/DateTime/Event/Recurrence.pm,v
retrieving revision 1.85
diff -d -u -r1.85 Recurrence.pm
--- lib/DateTime/Event/Recurrence.pm 22 Sep 2004 16:19:23 -0000 1.85
+++ lib/DateTime/Event/Recurrence.pm 7 Jan 2005 09:58:58 -0000
@@ -684,11 +684,11 @@
if ( $unit eq 'days' )
{
# map rfc2445 weekdays to numbers
- @{$args{$unit}} = map {
+ $args{$unit} = [ map {
$_ =~ /[a-z]/ ?
$_ = $weekdays{$_} :
$_
- } @{$args{$unit}};
+ } @{$args{$unit}} ];
}
@{$args{$unit}} = sort { $a <=> $b } @{$args{$unit}};
# put positive values first


However, I don't think this solves the whole problem.
It looks like there are a lot of

  @{ $args { $foo } } = @blah_blah;

type of constructs, and that's where this is all coming from.

If no one objects, I don't mind doing a sweep change and remove all such occurences. It's a three day weekend over in this corner of Asia.

--d




Reply via email to