> -----Original Message----- > From: Rick Measham [mailto:[EMAIL PROTECTED] > Sent: Saturday, April 22, 2006 11:16 PM > To: Garrett, Philip (MAN-Corporate) > Cc: datetime@perl.org > Subject: Re: from_epoch for DateTime::LazyInit? > > Garrett, Philip (MAN-Corporate) wrote: > > Whoops, the patch I sent earlier is botched. This one should be better. > > One thing I forgot was to update the POD -- I'll try to get that later. > > Thanks Philip, > I'd already noticed it wasn't working and fixed it .. :)
Doh! Sorry. > > I also added an overloadable class method __datetime_class() so that > > if you want to use a subclass of DateTime (as I do) then you can. > > I'm not sure I want to do this .. we don't do this sort of thing in > any other DateTime module (afaik) so until we work out if/how we want > to do it then I'm a little loathe to include it. > > Unless Dave and the rest of the DateTime team want to chime in, I'd > just suggest you overload the whole __inflate() routine. That's fine too. However, the underscores in front of the method name indicate to me that it's "extremely private." Making the DateTime class name overloadable is both easier for users (since they don't have to implement all the innards of __inflate) and more easily documented. My $0.02. Thanks, Philip
