On Sunday 07 December 2008, Felipe Balbi wrote:
> > +     platform_set_drvdata(pdev, keys);
> > +     keys->pdev = pdev;
> 
> you could be holding only the device pointer.
> 
>         keys->dev = &pdev->dev;
> 
> then, if you really happen to need the pdev pointer you can use
> 
> to_platform_device(keys->dev);

True, that would be a bit simpler; the device handle is what's
normally needed, e.g. for dev_dbg().  I'd take an update patch;
but for now I'll avoid a re-test cycle.  :)

- Dave

_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to