> -----Original Message----- > From: davinci-linux-open-source-boun...@linux.davincidsp.com > [mailto:davinci-linux-open-source-boun...@linux.davincidsp.com] On Behalf > Of David Brownell > Sent: Tuesday, January 27, 2009 1:22 AM > To: davinci-linux-open-source@linux.davincidsp.com > Subject: Re: DM6446: EDMA > > On Monday 26 January 2009, Brian G Rhodes wrote: > > I think someone forgot an 'I' in edma_stop. Writing to ECR seems > > pointless to me. I am assuming they meant to do SH_IECR instead of > > SH_ECR. This also happens to fix the problem I was having with audio > > stalls on dm6446. > > ECR == Event Clear Register, scrubbing out pending events > IECR == Interrupt Enable Clear Register, disabling completion IRQs > > Wouldn't it make sense to clear *both*?
Possibly, but there are some other considerations if you clear both. Namely once you re-enable the EDMA you would need the peripherals to generate new EDMA events. For example, with the ASP/McBSP you would need to turn it off and then back on. If you leave the event pending then you would not need to restart ASP/McBSP. Personally I think it's easier/cleaner to just let the event pend. Otherwise the EDMA driver code has to interact with peripherals too. _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
