> On Friday 20 February 2009, Purushotam Kumar wrote:
> > -       do {
> > -               status = readl(host->base + DAVINCI_MMCST0);
> > -               if (status == 0)
> > -                       break;
> > -               if (handle_core_command(host, status))
> > -                       break;
> > -       } while (1);
> > +       status = readl(host->base + DAVINCI_MMCST0);
> > +       handle_core_command(host, status);
> >         return IRQ_HANDLED;
> 
> Looks OK, but an even better cleanup would be to not have a
> needless separate function for this  ... :)

I will suggest let this patch go through because of it has lot of other 
cleaning as well and we could take up this suggestion as well in the 2nd round 
of cleaning.

Regards, 
Purushotam


_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to