> > Note I also just pushed the patch below to remove the use of cpu_is_* > from this driver since that check is redundant with pdata and I'm > trying to drop all the usage of cpu_is_* from davinci drivers in favor > of platform_data.
It's not actually redundant, since that's the "we have no pdata" case. It's just kicking in "use best ECC available" as commented. > If it's not too late, could you incorporate that into your push to > mainline. Simplest if you just send on that thread, as a followup, with the "remove <mach/cpu.h>" bit merged too ... and some kind of change to that "best available" comment. Andrew tends to merge all such fixups into the final push before sending it along (usually to Linux, maybe this time to the black-hole-that-is-MTD). Add my ack if you like. - Dave > Kevin > > commit f7a599f911ca0280d8c39cf34995338bead4c823 > Author: Kevin Hilman <[email protected]> > Date: Thu Feb 26 17:15:18 2009 -0800 > > MTD: NAND: drop usage of cpu_is_* macro > > Usage of davinci-specific cpu_is macros is not allowed in drivers. > These options should be passed in through platform_data. > > Signed-off-by: Kevin Hilman <[email protected]> > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index aa70b4e..633d1b0 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -392,8 +392,6 @@ static int __init nand_davinci_probe(struct > platform_device *pdev) > /* use board-specific ECC config; else, the best available */ > if (pdata) > ecc_mode = pdata->ecc_mode; > - else if (cpu_is_davinci_dm355()) > - ecc_mode = NAND_ECC_HW_SYNDROME; > else > ecc_mode = NAND_ECC_HW; > > > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
