On Mon, Mar 30, 2009 at 09:02:11PM -0700, Kevin Hilman wrote:
> "Mark A. Greer" <mgr...@mvista.com> writes:
> > diff --git a/arch/arm/mach-davinci/include/mach/common.h
> > b/arch/arm/mach-davinci/include/mach/common.h
> > index 7cb3e39..7d072e2 100644
> > --- a/arch/arm/mach-davinci/include/mach/common.h
> > +++ b/arch/arm/mach-davinci/include/mach/common.h
> > @@ -36,6 +36,11 @@ struct davinci_soc_info {
> > struct davinci_clk *cpu_clks;
> > void __iomem **psc_bases;
> > unsigned long psc_bases_num;
> > +#ifdef CONFIG_DAVINCI_MUX
> > + void __iomem *pinmux_base;
> > + const struct mux_config *pinmux_pins;
> > + unsigned long pinmux_pins_num;
> > +#endif
> > };
>
> drop the #ifdef from the struct as well.
>
> Basically, I have and aversion the #ifdefs in struct davinci_soc_info
> since it leads to extra #ifdefs in the code.
>
> The one around <soc>_pins[] makes more sense since it's a large array
> and would waste space.
OK
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
