Russell King - ARM Linux <li...@arm.linux.org.uk> writes:

> On Fri, May 15, 2009 at 05:58:20PM -0700, Kevin Hilman wrote:
>> The Davinci cpu_is_davinci_*() macros use the SoC part number
>> and variant retrieved from the JTAG ID register to determine the
>> type of cpu that the kernel is running on.
>
> Hmm.
>
> Can I suggest that we rethink the naming of these things.  The CPU
> is the core itself, not the whole SoC.  These should be called
> soc_is_davinci_xxx().
>
> Yes, I know that we've a lot of SoCs now which do this (eg, PXA)
> but I think it's something we should _eventually_ get right.
>
> (don't take that as an objection to this patch, merely an observation
> and a todo item.)

ok, added to TODO list


_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to