"Paulraj, Sandeep" <[email protected]> writes: > Kevin, > Please see inline > >> -----Original Message----- >> From: Kevin Hilman [mailto:[email protected]] >> Sent: Tuesday, June 02, 2009 6:03 PM >> To: Paulraj, Sandeep >> Cc: [email protected] >> Subject: Re: [PATCH] Adding Support for DM355 SPI >> >> "Paulraj, Sandeep" <[email protected]> writes: >> >> >> -----Original Message----- >> >> From: Kevin Hilman [mailto:[email protected]] >> >> Sent: Tuesday, June 02, 2009 4:46 PM >> >> To: Paulraj, Sandeep >> >> Cc: [email protected] >> >> Subject: Re: [PATCH] Adding Support for DM355 SPI >> >> >> >> "Paulraj, Sandeep" <[email protected]> writes: >> >> >> >> > SPI does not build by default in the present config. >> >> > SPI needs to be enabled first. >> >> > Once this is done through menuconfig, the SPI EEPROM driver( >> >> miscellaneous >> >> > Driver) needs to be enabled. >> >> >> >> How about a including defconfig updates to build the above as modules >> >> in this patch. >> > [Sandeep] That can be done. Anyway I have to submit another set of >> patches >> > But why as a module? Why not just build it statically by default? >> >> I'd prefer it as a module in _all_defconfig because it may not be >> needed on all platforms enabled in the _all_defconfig. > [Sandeep] Understood > It can be >> enabled in the device specific defconfigs as required, when/if there >> are maintainers for those. > > [Sandeep] I think we will need a DM355 defconfig. Infact in our GIT > release we will have a DM355 Defconfig. > > Is it OK with you if I submit a DM355 defconfig patch tomorrow. > I think I can maintain that.
Yes, I will accept/merge the dm355 defconfig, but will not keep it updated. Please also update the all_defconfig to build SPI as modules with your patch. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
