s-paul...@ti.com writes:

> Patch adds DM365 entries in the Kconfig and makefile 
>
> Signed-off-by: Sandeep Paulraj <s-paul...@ti.com>
> ---
>  arch/arm/mach-davinci/Kconfig  |   12 ++++++++++++
>  arch/arm/mach-davinci/Makefile |    2 ++
>  2 files changed, 14 insertions(+), 0 deletions(-)

You should add the Kconfig/Makefile/defconfig changes at the end of
the series.

> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index c460615..bcf734e 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -22,6 +22,10 @@ config ARCH_DAVINCI_DM355
>          bool "DaVinci 355 based system"
>       select AINTC
>  
> +config ARCH_DAVINCI_DM365
> +        bool "DaVinci 365 based system"
> +     select AINTC

Alignment?  'bool' line has spaces, 'select' line has tab.

>  comment "DaVinci Board Type"
>  
>  config MACH_DAVINCI_EVM
> @@ -48,6 +52,14 @@ config MACH_DAVINCI_DM355_EVM
>         Configure this option to specify the whether the board used
>         for development is a DM355 EVM
>  
> +config MACH_DAVINCI_DM365_EVM
> +     bool "TI DM365 EVM"
> +     default n

Make this 'default ARCH_DAVINCI_DM365' so the EVM board defaults to be
enabled whenever the SoC is enabled.

I"ve been meaning to do this for the other SoCs as well.

> +     depends on ARCH_DAVINCI_DM365
> +     help
> +       Configure this option to specify the whether the board used
> +       for development is a DM365 EVM
> +
>  config MACH_SFFSDR
>       bool "Lyrtech SFFSDR"
>       default n
> diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile
> index 6da7b63..18a3870 100644
> --- a/arch/arm/mach-davinci/Makefile
> +++ b/arch/arm/mach-davinci/Makefile
> @@ -14,6 +14,7 @@ obj-$(CONFIG_DAVINCI_MUX)           += mux.o
>  obj-$(CONFIG_ARCH_DAVINCI_DM644x)       += dm644x.o
>  obj-$(CONFIG_ARCH_DAVINCI_DM646x)       += dm646x.o
>  obj-$(CONFIG_ARCH_DAVINCI_DM355)        += dm355.o
> +obj-$(CONFIG_ARCH_DAVINCI_DM365)        += dm365.o

You add building of files that are not yet added.  This
breaks the ability to git bisect.

>  obj-$(CONFIG_AINTC)                  += irq.o
>  obj-$(CONFIG_CP_INTC)                        += cp_intc.o
> @@ -22,6 +23,7 @@ obj-$(CONFIG_CP_INTC)                       += cp_intc.o
>  obj-$(CONFIG_MACH_DAVINCI_EVM)       += board-dm644x-evm.o
>  obj-$(CONFIG_MACH_DAVINCI_DM6467_EVM)        += board-dm646x-evm.o
>  obj-$(CONFIG_MACH_DAVINCI_DM355_EVM) += board-dm355-evm.o
> +obj-$(CONFIG_MACH_DAVINCI_DM365_EVM) += board-dm365-evm.o
>  obj-$(CONFIG_MACH_SFFSDR)            += board-sffsdr.o
>  obj-$(CONFIG_MACH_DM355_LEOPARD)     += board-dm355-leopard.o

Ditto.  This is why the Makefile changes should go at the end.

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to