>> >> My first reaction to this is... no. I'm reluctant to have a bunch of >> driver specific hooks in the core davinci SoC specific code. I'd much >> rather see this stuff kept along with the driver in drivers/media/* >> and abstracted as necessary there. > >I agree with Kevin on this. arch/* is mostly meant for platform-specific >infrastructure code. Device drivers should go in drivers/*. The >VPSS/VPFE/CCDC/... abstraction should live in drivers/media/video/*. SoC- >specific code that can be shared between multiple drivers (I remember we >discussed IRQ routing for instance) can go in arch/*. > [MK] yes. As per your definition vpss module registers are shared across all video drivers. So it appears it has to go in arch/*. But I am now more inclined to write a platform driver for vpss that live inside media/video/davinci/ and shall export a bunch of library functions shared across drivers. I will make this change and will send it as part of v2 version of the patch series...
_______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
