On Sunday 21 June 2009, s-paul...@ti.com wrote: > In the mean while i'd like comments on the driver itself.
CC drivers/input/keyboard/dm365evm_keypad.o drivers/input/keyboard/dm365evm_keypad.c: In function 'dm365_kp_probe': drivers/input/keyboard/dm365evm_keypad.c:112: warning: unused variable 'val' :) > Since it is DM365 EVM specific, i add all the structures in > the board specific file rather than the DM365 SOC file Look at how the OMAP drivers handle this. It should *NOT* be a board-specific driver. Use platform_data to feed in a table that maps scan codes (from the hardware) to symbolic keycodes. The next dm365 board should be able to re-use this driver and just feed it a different table. This is a different situation from the dm355 keypad, which is highly specific to that board's msp430 firmware. - Dave _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
