Hi, On Sat, Jun 20, 2009 at 03:49:18, Kevin Hilman wrote: > "Rajashekhara, Sudhakar" <sudhakar....@ti.com> writes: > > > DA850/OMAP-L138 is the next generation DA830/OMAP-L137 processor > > from TI. > > > > DA830 and DA850 have many things in common. Instead of adding > > new files for DA850 reuse the existing DA830 files by renaming > > da830-xxx files to da8xx-xxx. Also rename common macros and > > functions that have da830 string in them to da8xx. > > > > A new config variable CONFIG_ARCH_DAVINCI_DA8XX, is added > > to group DA830 and DA850 architectures. > > > > Signed-off-by: Sudhakar Rajashekhara <sudhakar....@ti.com> > > Signed-off-by: Sekhar Nori <nsek...@ti.com> > > Content-wise, this looks fine, some requests below... > > > --- > > arch/arm/mach-davinci/Kconfig | 4 + > > arch/arm/mach-davinci/Makefile | 2 +- > > arch/arm/mach-davinci/Makefile.boot | 4 +- > > arch/arm/mach-davinci/board-da830-evm.c | 14 +- > > arch/arm/mach-davinci/da830.c | 236 +++++++++--------- > > arch/arm/mach-davinci/devices-da830.c | 266 -------------------- > > arch/arm/mach-davinci/devices-da8xx.c | 280 ++++++++++++++++++++++ > > Please use 'git mv' when renaming files.
OK. > > > arch/arm/mach-davinci/include/mach/da830.h | 69 ------ > > arch/arm/mach-davinci/include/mach/da8xx.h | 69 ++++++ > > arch/arm/mach-davinci/include/mach/debug-macro.S | 6 +- > > arch/arm/mach-davinci/include/mach/irqs.h | 148 ++++++------ > > arch/arm/mach-davinci/include/mach/memory.h | 6 +- > > arch/arm/mach-davinci/include/mach/psc.h | 70 +++--- > > arch/arm/mach-davinci/include/mach/serial.h | 6 +- > > arch/arm/mach-davinci/include/mach/uncompress.h | 2 +- > > 15 files changed, 602 insertions(+), 580 deletions(-) > > delete mode 100644 arch/arm/mach-davinci/devices-da830.c > > create mode 100644 arch/arm/mach-davinci/devices-da8xx.c > > delete mode 100644 arch/arm/mach-davinci/include/mach/da830.h > > create mode 100644 arch/arm/mach-davinci/include/mach/da8xx.h > > Also, I'd like to merge this together with Mark's original series > before submitting upstream. > > Therefore, to make that easier, could you break this up into two > patches. One that touches the files in Mark's SoC support (commit > 40e1b943581b2d92ab2f5b4750a554ff00b51323) and a 2nd that touches > the files in Mark's EVM support (commit 32b9fa0df29d31e01b28c3296c3b0ed744a775da) > > Thanks, > > Kevin > I'll rework on the patch as per your suggestion and will submit the updated version. Thanks, Sudhakar _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
