On Tue, Jul 07, 2009 at 00:02:00, Kevin Hilman wrote:
> "Rajashekhara, Sudhakar" <sudhakar....@ti.com> writes:
> 
> > On Wed, Jul 01, 2009 at 23:24:21, Kevin Hilman wrote:
> >> "Rajashekhara, Sudhakar" <sudhakar....@ti.com> writes:
> >> 
> >> > This patch also fixes broken CONFIG_DEBUG_LL support on 
> >> > DA830/OMAP-L137 EVM caused by my previous patch.
> >> 
> >> hmm...
> >> 
> >> > diff --git a/arch/arm/mach-davinci/include/mach/uncompress.h 
> >> > b/arch/arm/mach-davinci/include/mach/uncompress.h
> >> > index 0f1f12b..28ea1f5 100644
> >> > --- a/arch/arm/mach-davinci/include/mach/uncompress.h
> >> > +++ b/arch/arm/mach-davinci/include/mach/uncompress.h
> >> > @@ -21,7 +21,8 @@ static u32 *uart;
> >> >  
> >> >  static u32 *get_uart_base(void)
> >> >  {
> >> > -        if (__machine_arch_type == MACH_TYPE_DAVINCI_DA8XX_EVM)
> >> > +        if (__machine_arch_type == MACH_TYPE_DAVINCI_DA8XX_EVM ||
> >> > +                __machine_arch_type == MACH_TYPE_DAVINCI_DA850_EVM)
> >> >                  return (u32 *)DA8XX_UART2_BASE;
> >> >          else
> >> >                  return (u32 *)DAVINCI_UART0_BASE;
> >> 
> >> this looks still broken for da830 since ..._DA8XX_EVM machine doesn't 
> >> exist.
> >> 
> >
> > No, it's not broken. DA830 EVM has been registered as DAVINCI_DA8XX_EVM.
> > Please refer to arch/arm/tools/mach-types.
> 
> Then the machine type was registered incorrectly as that is clearly a
> wrong (and confusing) name for that board.
> 
> Please fix the machine-name registration and send a mach-types patch
> along with an updated version of this patch.
> 

FYI, I did not register DA830 board. Now if I register the DA830 again,
u-boot will break because.

Can I submit a patch against mach-types file to Russell King, which
changes the the EVM name to ..._DA830_EVM from ..._DA8XX_EVM?

Regards, Sudhakar


_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to