Murali, I am working on OMAP L 138 based Low cost platform. This has Composite IN port, I would like to write driver for this peripheral.
Thought of using your patches for the same. Regards, Khasim ________________________________ From: Karicheri, Muralidharan Sent: Monday, August 17, 2009 9:40 PM To: Syed Mohammed, Khasim; Stijn Devriendt; Davinci-linux-open-source@linux.davincidsp.com Subject: RE: [PATCH v1 - 3/5] V4L : vpif capture driver for DM6467 Khasim, Could you let me know what you are trying to do? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com ________________________________ From: Syed Mohammed, Khasim Sent: Monday, August 17, 2009 12:02 PM To: Karicheri, Muralidharan; Stijn Devriendt; Davinci-linux-open-source@linux.davincidsp.com Subject: RE: [PATCH v1 - 3/5] V4L : vpif capture driver for DM6467 Hi Murali, Thanks for confirming this, I will give a try later this week. Will get in touch with you. Regards, Khasim ________________________________ From: Karicheri, Muralidharan Sent: Monday, August 17, 2009 9:24 PM To: Syed Mohammed, Khasim; Stijn Devriendt; Davinci-linux-open-source@linux.davincidsp.com Subject: RE: [PATCH v1 - 3/5] V4L : vpif capture driver for DM6467 Khasim, I think you are talking about Freon. Yes, the plan is to re-use the driver for Freon. If there are no register changes, then just adding the vpif configuration data such as register io address, irq etc in the board/platform specific files, it would work on Freon. Minor changes to the register will require customization in the vpif.c and vpif.h. If there are any difference in the way encoder/decoder chips are connected to the vpif input or output, we just need to change a function in the board specific file that switches the input or output to the vpif. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com ________________________________ From: Syed Mohammed, Khasim Sent: Saturday, August 15, 2009 3:12 AM To: Stijn Devriendt; Karicheri, Muralidharan; Davinci-linux-open-source@linux.davincidsp.com Subject: RE: [PATCH v1 - 3/5] V4L : vpif capture driver for DM6467 Are we taking care of OMAP L 138 as well, since this chipset has similar VPIF module, I expect we should be leveraging this code base as is. Regards, Khasim ________________________________ From: davinci-linux-open-source-boun...@linux.davincidsp.com [mailto:davinci-linux-open-source-boun...@linux.davincidsp.com] On Behalf Of Stijn Devriendt Sent: Saturday, August 15, 2009 11:49 AM To: Karicheri, Muralidharan; Davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH v1 - 3/5] V4L : vpif capture driver for DM6467 This code is so EVM specific, instead of SOC-specific. In order to connect 2 DM646x chips directly via VPIF this driver requires quite a bit of tweaking. (I know because I had to do this before ;) ) I'd appreciate a more loosely coupled subdevice layer. VPIF itself doesn't use I2C so this stuff should belong elsewhere. Secondly I can imagine any board other than the EVM uses other codec chips (either I2C or not). So basically the whole codec stuff would preferable be split out of the core VPIF driver. Regards, Stijn +/** + * vpif_probe : This function probes the vpif capture driver + * @pdev: platform device pointer + * + * This creates device entries by register itself to the V4L2 driver and + * initializes fields of each channel objects + */ +static __init int vpif_probe(struct platform_device *pdev) +{ + struct vpif_subdev_info *subdevdata; + struct vpif_capture_config *config; + int i, j, k, m, q, err; + struct i2c_adapter *i2c_adap; + struct channel_obj *ch; + struct common_obj *common; + struct video_device *vfd; + struct resource *res; + int subdev_count; + + vpif_dev = &pdev->dev; + + err = initialize_vpif(); + if (err) { + v4l2_err(vpif_dev->driver, "Error initializing vpif\n"); + return err; + } + + k = 0; + while ((res = platform_get_resource(pdev, IORESOURCE_IRQ, k))) { + for (i = res->start; i <= res->end; i++) { + if (request_irq(i, vpif_channel_isr, IRQF_DISABLED, + "DM646x_Capture", + (void *)(&vpif_obj.dev[k]->channel_id))) { + err = -EBUSY; + i--; + goto vpif_int_err; + } + } + k++; + } + + for (i = 0; i < VPIF_CAPTURE_MAX_DEVICES; i++) { + /* Get the pointer to the channel object */ + ch = vpif_obj.dev[i]; + /* Allocate memory for video device */ + vfd = video_device_alloc(); + if (NULL == vfd) { + for (j = 0; j < i; j++) { + ch = vpif_obj.dev[j]; + video_device_release(ch->video_dev); + } + err = -ENOMEM; + goto vpif_dev_alloc_err; + } + + /* Initialize field of video device */ + *vfd = vpif_video_template; + vfd->v4l2_dev = &vpif_obj.v4l2_dev; + vfd->release = video_device_release; + snprintf(vfd->name, sizeof(vfd->name), + "DM646x_VPIFCapture_DRIVER_V%d.%d.%d", + (VPIF_CAPTURE_VERSION_CODE >> 16) & 0xff, + (VPIF_CAPTURE_VERSION_CODE >> 8) & 0xff, + (VPIF_CAPTURE_VERSION_CODE) & 0xff); + /* Set video_dev to the video device */ + ch->video_dev = vfd; + } + + for (j = 0; j < VPIF_CAPTURE_MAX_DEVICES; j++) { + ch = vpif_obj.dev[j]; + ch->channel_id = j; + common = &(ch->common[VPIF_VIDEO_INDEX]); + spin_lock_init(&common->irqlock); + mutex_init(&common->lock); + /* Initialize prio member of channel object */ + v4l2_prio_init(&ch->prio); + err = video_register_device(ch->video_dev, + VFL_TYPE_GRABBER, (j ? 1 : 0)); + if (err) + goto probe_out; + + video_set_drvdata(ch->video_dev, ch); + + } + + i2c_adap = i2c_get_adapter(1); + config = pdev->dev.platform_data; + + subdev_count = config->subdev_count; + vpif_obj.sd<http://vpif_obj.sd> = kmalloc(sizeof(struct v4l2_subdev *) * subdev_count, + GFP_KERNEL); + if (vpif_obj.sd<http://vpif_obj.sd> == NULL) { + vpif_err("unable to allocate memory for subdevice pointers\n"); + err = -ENOMEM; + goto probe_out; + } + + err = v4l2_device_register(vpif_dev, &vpif_obj.v4l2_dev); + if (err) { + v4l2_err(vpif_dev->driver, "Error registering v4l2 device\n"); + goto probe_subdev_out; + } + + for (i = 0; i < subdev_count; i++) { + subdevdata = &config->subdev_info[i]; + vpif_obj.sd<http://vpif_obj.sd>[i] = + v4l2_i2c_new_subdev_board(&vpif_obj.v4l2_dev, + i2c_adap, + subdevdata->name, + &subdevdata->board_info, + NULL); + + if (!vpif_obj.sd<http://vpif_obj.sd>[i]) { + vpif_err("Error registering v4l2 subdevice\n"); + goto probe_subdev_out; + } + v4l2_info(&vpif_obj.v4l2_dev, "registered sub device %s\n", + subdevdata->name); + + if (vpif_obj.sd<http://vpif_obj.sd>[i]) + vpif_obj.sd<http://vpif_obj.sd>[i]->grp_id = 1 << i; + } + v4l2_info(&vpif_obj.v4l2_dev, "DM646x VPIF Capture driver" + " initialized\n"); + + return 0; + +probe_subdev_out: + /* free sub devices memory */ + kfree(vpif_obj.sd<http://vpif_obj.sd>); + + j = VPIF_CAPTURE_MAX_DEVICES; +probe_out: + v4l2_device_unregister(&vpif_obj.v4l2_dev); + for (k = 0; k < j; k++) { + /* Get the pointer to the channel object */ + ch = vpif_obj.dev[k]; + /* Unregister video device */ + video_unregister_device(ch->video_dev); + } + +vpif_dev_alloc_err: + k = VPIF_CAPTURE_MAX_DEVICES-1; + res = platform_get_resource(pdev, IORESOURCE_IRQ, k); + i = res->end; + +vpif_int_err: + for (q = k; q >= 0; q--) { + for (m = i; m >= (int)res->start; m--) + free_irq(m, (void *)(&vpif_obj.dev[q]->channel_id)); + + res = platform_get_resource(pdev, IORESOURCE_IRQ, q-1); + if (res) + i = res->end; + } + return err; +} +
_______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
