On Mon, Oct 05, 2009 at 19:32:03, Miguel Aguilar wrote: > Sekhar, > > > Nori, Sekhar wrote: > > On Sat, Oct 03, 2009 at 00:32:30, [email protected] wrote: > >> From: Miguel Aguilar <[email protected]> > >> > >> Adds the driver for enabling keypad support for DaVinci platforms. > >> > >> DM365 is the only platform that uses this driver at the moment. > >> > >> Signed-off-by: Miguel Aguilar <[email protected]> > > > > [...] > > > > > > I see you have retracted the earlier implementation using > > ffs(). I think you said the device can handle only one key > > state change per interrupt, the loop is not needed if that's > > the case. > The current implementation checks the state of all the state bits which is > better than just checking one bit with ffs.
Even in this case ffs() can be used by running these two statements in a loop: key = ffs(changed); changed >>= key; But, I cant say if it will necessarily speed up the ISR, so I will leave to your judgment (or liking). Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
