On Fri, Oct 09, 2009 at 06:40:22, Mark A. Greer wrote: > On Thu, Oct 08, 2009 at 10:37:05AM +0530, Nori, Sekhar wrote: > > On Wed, Oct 07, 2009 at 23:05:48, Mark A. Greer wrote: > > > On Mon, Oct 05, 2009 at 11:12:17AM +0530, Nori, Sekhar wrote: > > > > On Fri, Oct 02, 2009 at 02:24:17, Mark A. Greer wrote: > > > > > > > > I don't know Sekhar... This looks like a step backwards to me with > > > > > all > > > > > the #ifdef-ery. Why not keep the code as it is and change the #ifdefs > > > > > that are already there (e.g., change the CONFIG_UI ones to CONFIG_FB, > > > > > etc)? > > > > > > > > Mark, > > > > > > > > The only new #ifdef the patch introduces is for MMC/SD. That is > > > > to make sure plugging in UI card does not get MMC to stop working. > > > > > > You have taken #ifdef's that included/excluded code and replaced them with > > > #ifdef's that are a part of the runtime logic. That's typically frowned > > > upon. That's my issue. > > > > Hmm. Honestly I did not know this was frowned upon. Why is it > > frowned upon? > > #ifdef's in general are frowned upon, see > Documentation/SubmittingPatches section 2.2.
The current code has a violation of this in da830_evm_init(). I just submitted a fix for this. Also fixed the warning issue. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
