Hello,
On Mon, Nov 02, 2009 at 00:18:28, Sameer Naik wrote:
> Hi,
> Please find attached a fix to davincifb.c.
> I am new to git and am not aware of the procedure to be followed while
> submitting patches. I have generated the by doing
> $ git diff > davincifb.patch
>
> If i need to follow a particular procedure while submitting patches
> please guide me in doing so. Following is the patch description
You should instead commit your changes (git-commit), prepare
a patch using git-format-patch and send using git-send-email
> ---
> ISSUE: If a window other than VID0 is disabled at boot time, then the
> kernel wont boot.
> Through my investigation is found that illegal accesses are made to
> the disabled windows in davincifb_isr(), for example if VID1 is
> disabled then an access is still made via xchg(&addr,
> dm->vid1->sdram_address) in davinfb_isr() due to which the kernel
> won't boot as dm->vid1 is NULL.
>
> The patch adds a check to verify that the dm->{osd0,osd1,vid1}
> variables are not NULL before the access is made. the check is not
> added for VID0 window because if VID0 is disabled then all the windows
> are disabled and the ISR itself is not registered.
>
> I have tested this patch on dm6446 at PAL COMPOSITE resolution.
This part looks like the actual patch description and should
be above the '---'. git-format-patch automatically makes the
commit message as subject + patch description.
Your current subject could also be more descriptive, IMO.
Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
