raghav n <raghav.m...@gmail.com> writes: > [PATCH 1/1] MMC: DaVinci: Fixed typos in comments of the response registers > in davinci_mmc.c
You don't need to duplicate the subject in the changelog. > This patch fixes the typos in the comments for the MMC response registers. > They were all /* Response Register 0 and 1 */ > > Signed-off-by: raghav.m...@gmail.com Thanks, will que > --- > From 08e00d18ca5d0c20a9035c631e7fcb5f39c88cb8 Mon Sep 17 00:00:00 2001 > From: raghav <raghav.m...@gmail.com> > > Date: Tue, 5 Jan 2010 23:57:17 +0530 > Subject: [PATCH] Fixed comments for the response registers. They were all > saying Regiser 0 and 1. You've got duplicate headers/changelog etc. here. I highly recommend using git-format-patch + git-send-email to send patches? > --- > drivers/mmc/host/davinci_mmc.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) The patch itself looks fine. After cleaning up the changelog, I'll queue for 2.6.33-rc fixes series. Kevin > > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index dd45e7c..73a6a14 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c > @@ -54,9 +54,9 @@ > #define DAVINCI_MMCCMD 0x30 /* Command Register */ > > > #define DAVINCI_MMCARGHL 0x34 /* Argument Register */ > #define DAVINCI_MMCRSP01 0x38 /* Response Register 0 and 1 */ > -#define DAVINCI_MMCRSP23 0x3C /* Response Register 0 and 1 */ > > > -#define DAVINCI_MMCRSP45 0x40 /* Response Register 0 and 1 */ > -#define DAVINCI_MMCRSP67 0x44 /* Response Register 0 and 1 */ > +#define DAVINCI_MMCRSP23 0x3C /* Response Register 2 and 3 */ > > > +#define DAVINCI_MMCRSP45 0x40 /* Response Register 4 and 5 */ > +#define DAVINCI_MMCRSP67 0x44 /* Response Register 6 and 7 */ > #define DAVINCI_MMCDRSP 0x48 /* Data Response Register */ > > > #define DAVINCI_MMCETOK 0x4C > #define DAVINCI_MMCCIDX 0x50 /* Command Index Register */ > -- > 1.6.0.4 > > > _______________________________________________ > Davinci-linux-open-source mailing list > Davinci-linux-open-source@linux.davincidsp.com > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
